Christopher M. Punches
97b39cac6c
A module is addressed by name and command string, and nothing else. Typed API access handed a caller a pointer into the callee's function table, which meant compiling against that module's struct layout — a build-time dependency between modules that the design does not permit. Removing it also removes the manifest, the table magic constant, and the table size field, which existed only to describe and validate those tables. Load validation is now three steps: reserved contract symbols resolve, the minimum-version handshake passes, and the version and description probes return well-formed values. The contract is four reserved symbols, and a module's interface is the command vocabulary it documents. Documentation is brought in line, and artifacts are named exactly: libdpm-core.so for the library, <dpm/core.h> for the header, the dpm binary for the command-line tool.
47 lines
1.4 KiB
C++
47 lines
1.4 KiB
C++
/**
|
|
* @file bad_version.cpp
|
|
* @brief Broken fixture: malformed module version string
|
|
*
|
|
* Contract-complete, but dpm_module_version() returns something that
|
|
* is not X.Y.Z. libdpm-core must refuse it at validation step 3.
|
|
*
|
|
* Part of the Dark Horse Linux Package Manager (DPM)
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as
|
|
* published by the Free Software Foundation, either version 3 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
extern "C" const char* dpm_module_version(void)
|
|
{
|
|
return "banana";
|
|
}
|
|
|
|
extern "C" const char* dpm_module_description(void)
|
|
{
|
|
return "Fixture with a malformed version.";
|
|
}
|
|
|
|
extern "C" const char* dpm_module_core_min(void)
|
|
{
|
|
return "0.1.0";
|
|
}
|
|
|
|
extern "C" int dpm_module_execute(void* ctx, const char* command,
|
|
int argc, char** argv)
|
|
{
|
|
(void)ctx;
|
|
(void)command;
|
|
(void)argc;
|
|
(void)argv;
|
|
return 0;
|
|
}
|
